Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| inline void fill_write_buffer(); | ||
|
|
||
| uint32_t m_skipLength; | ||
| uint32_t m_skipLength{}; |
There was a problem hiding this comment.
invalid case style for private member m_skipLength
Suggested change
| uint32_t m_skipLength{}; | |
| uint32_t m_skip_length{}; |
rakshasa
reviewed
Jul 28, 2025
rakshasa
reviewed
Jul 28, 2025
rakshasa
reviewed
Jul 28, 2025
rakshasa
reviewed
Jul 28, 2025
neheb
force-pushed
the
cppc
branch
2 times, most recently
from
b5e9fed to
c673cba
Compare
rakshasa
reviewed
Aug 2, 2025
| inline DataBuffer | ||
| DataBuffer::release() { | ||
| set_data(nullptr, 0, false); | ||
| return *this; |
rakshasa
reviewed
Aug 2, 2025
|
|
||
| memcpy(m_pending.end(), buffer + (piece << metadata_piece_shift), length); | ||
| m_pending.set(m_pending.data(), m_pending.end() + length, m_pending.owned()); | ||
| m_pending.set_data(m_pending.data(), length, m_pending.owned()); |
rakshasa
reviewed
Sep 1, 2025
| const char* | ||
| strerror(int err) { | ||
| if (err < 0 || err > e_last) | ||
| if (err < 0 || err >= e_last) |
Owner
There was a problem hiding this comment.
This is incorrect, we use e_last+1 above.
Found with useStlAlgorithm Signed-off-by: Rosen Penev <rosenp@gmail.com>
No need to specify the typename. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with derefInvalidIteratorRedundantCheck Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with derefInvalidIterator Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with noConstructor Signed-off-by: Rosen Penev <rosenp@gmail.com>
Avoids having to pass nullptr. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.